Make lastActiveItemIndex public, so selection on hover can be implemented #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, go for it! One of the next factoring will be to handle style and item state for the items, this will allow us to expose hovered pressed and selected states for each item. |
fscarponi
approved these changes
Oct 23, 2023
fscarponi
reviewed
Oct 23, 2023
|
@fscarponi this is a Kotlin property, so it's always getter and setter functions |
did you need to set this property from the outside? |
|
Yes, this is the intention, to be able to set it outside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case of selection on hover it is needed to manually modify lastActiveItemIndex, so let's make it public